Disabling this button in jquery

Question

I have got this button <button id="beg" onclick"disable()">beg</button>. And function is defined here

function disable(time){
    $(this).attr('disabled', 'disabled');
};

Problem is that button doesn't get disabled, I have no idea why.

Thank you.

Duplicate of http://stackoverflow.com/questions/3014649/how-to-disable-html-button-using-javascript — Adrian Marinica, Nov 20 '13 at 12:31
That question doesnt answer my question, so it's not duplicate. — Kyrbi, Nov 20 '13 at 12:34

score 7 · Accepted Answer · edited Nov 20 '13 at 12:34

7

It's because this in your function is not a reference to the button element. Try this:

<button id="beg" onclick="disable(this)">beg</button>

function disable(el){
    $(el).attr('disabled', 'disabled');
};

Or better yet, separate your HTML and JS completely by hooking up your event in JS:

<button id="beg">beg</button>

$('#beg').click(function() {
    $(this).prop('disabled', true);
});

edited Nov 20 '13 at 12:34

VisioN

answered Nov 20 '13 at 12:31

Rory McCrossan

1

That was too fast +1. – VisioN Nov 20 '13 at 12:33
Is missing a =? Like ? – Irvin Dominin Nov 20 '13 at 12:33
@IrvinDomininakaEdward ah yes, thanks. Also thanks VisioN for the edit. – Rory McCrossan Nov 20 '13 at 12:35
Can you explain me that (el), please? – Kyrbi Nov 20 '13 at 12:36
@Kyrbi `el` is the variable holding the reference to the element which was clicked on. – Rory McCrossan Nov 20 '13 at 12:36

1 Answers1