Editing MYSQL with PHP

Question

I have a database which has edit buttons on each entry but I get this error when trying to edit an item.

Warning: mysql_fetch_array() expects parameter 1 to be resource, boolean given in /editentry.php on line 32

Here is the line in question and files corresponding to the problem.

$order = "SELECT * FROM Missions WHERE MissionNumber='$id'";

Missions.php labels all the entries with the edit button next to them - http://pastebin.com/VbTzUMDP

editentry.php is the page where the editing should take place where the error occurs - http://pastebin.com/fj7y9GFW

Also I am aware that this code has the chance of being SQL injected, but this is only some testing code for the moment with a page that can only be accessed by me.

Run `mysql_error()` and echo that out. Also, echo out your `$sql`. And if `$id` is always a number, try typecasting `(int)$id` — Machavity, Nov 14 '13 at 04:35
The mysql extension is deprecated as of PHP 5.5, use PDO or mysqli — joschua011, Nov 14 '13 at 04:36

score 1 · Accepted Answer · answered Nov 14 '13 at 04:41

1

Try changing it to add the connection in your mysql_query() before you mysql_fetch_array():

 $con = mysql_connect($hostname, $username, $password) OR DIE ("Unable to
       connect to database! Please try again later.");
 mysql_select_db($dbname,$con);
 $data = mysql_query("SELECT * FROM Missions ORDER BY CashPayout DESC",$con) 
 or die(mysql_error());
 $info = mysql_fetch_array( $data );

By the way mysqli and PDO is preferred as it is more safe and secure.

answered Nov 14 '13 at 04:41

Edper

8,869
1
25
46

2

That worked thankyou. I will be updating all my code to myqsqli soon. Just need to run a lot of test with this system first. – user2977587 Nov 14 '13 at 04:47
Glad to be of help @user2977587. Happy coding and GOD bless. – Edper Nov 14 '13 at 06:25

score 0 · Answer 2 · answered Nov 14 '13 at 04:38

0

When error in query then this type of error is show.. Try This:-

$id = $_GET['id'];
$order = "SELECT * FROM Missions WHERE MissionNumber = '".$id."' ";

answered Nov 14 '13 at 04:38

Sandesh

353
2
8

Still returns the same error. – user2977587 Nov 14 '13 at 04:40
Check Table name & column name – Sandesh Nov 14 '13 at 04:43

score 0 · Answer 3 · answered Nov 14 '13 at 04:46

0

mysql_fetch_array() FALSE on failure or when there are no more rows. you can use back tick in your query and check , the value of $id you are getting or not.

$order = "SELECT * FROM `Missions` WHERE `MissionNumber` = '$id'";

answered Nov 14 '13 at 04:46

Dinesh

3,886
4
20
33

score 0 · Answer 4 · edited Nov 14 '13 at 05:19

0

There is an error in your query, use below code of line instead:

$order = sprintf("SELECT * FROM Missions WHERE MissionNumber='%s'",$id);

edited Nov 14 '13 at 05:19

Raptor

51,208
43
217
353

answered Nov 14 '13 at 05:11

Rumana

1
1
1

Editing MYSQL with PHP

4 Answers4