Getting "Warning: mysql_num_rows() expects parameter 1 to be resource, boolean given"

Question

I'm getting an error as per the title, on line 14. I'm very new to php, I login and this code throws an error on logging in to the index page. I am able to login though (not too sure how).

<?php
include 'functions.php';
include_once("config.php");
session_start();
if(!isset($_SESSION["email"])){
  header("location: login.php");
  exit();
}
$id = preg_replace('#[^0-9]#i', '',$_SESSION["id"]);
$email = preg_replace('#[^A-Za-z0-9]#i', '', $_SESSION["email"]);
$password = preg_replace('#[^A-Za-z0-9]#i', '', $_SESSION["password"]);
include "db_connect.php";
$sql=mysql_query("SELECT * FROM 'members' WHERE id - ? LIMIT 1"); // query the person
$existCount=mysql_num_rows($sql); // count the nums
if ($existCount==1){//evaluate the count
  echo "Your login session data is not on record in the database";
  exit();
}
?>

We're not going to be able to help without seeing your code. — Amal Murali, Oct 20 '13 at 16:32
See [this answer](http://stackoverflow.com/a/11674313/250259) for how to troubleshoot this. — John Conde, Oct 20 '13 at 16:34
table name cannot be enclosed in quotes, use backticks instead. — nurakantech, Oct 20 '13 at 16:36
ok, i seemed to have fixed it, i now get "Your login session data is not on record in the database" so, i guess it's working.. or not? ha — suggsy89, Oct 20 '13 at 16:40

score 0 · Answer 1 · answered Oct 20 '13 at 16:40

Your SQL Statement is incomplete:

Instead of


    $sql=mysql_query("SELECT * FROM 'members' WHERE id - ? LIMIT 1"); // query the person

use this


    $sql=mysql_query("SELECT * FROM members WHERE id ="."'".$id."'"." and password ="."'".$password."' LIMIT 1"); // query the person

that is ofcourse assuming you are using your password as is (which is not a good idea). You should encode it before storing it in the database.

score -1 · Answer 2 · answered Oct 20 '13 at 16:40

Just correct your query statement like this:

<?php
 $sql = "SELECT * FROM `members` WHERE id = '{$id}' LIMIT 1";
 // `members` can also be simply members only but don't use quotes like ('', or "")
 ?>

Query this statement and you will get yourself out of the problem.
Bit of suggestion mysql_* is officially deprecated, so use mysqli or PDO.

Getting "Warning: mysql_num_rows() expects parameter 1 to be resource, boolean given"

2 Answers2