sending a string from php to javascript function

Question

Im tring to pass a string which im getting from my database to a javascript function.

In my php I have:

<input type="image" name="edit_me" id="edit_me"  value="<?php echo $row['id']; ?>" onClick="edit_chirp(<?php echo $row['id']; ?>)"/> //THIS WORKS

When I pass the id im getting it works fine but when I pass a field where it has text it doesnt work.

<input style="float:right" type="image" name="edit_me" id="edit_me"  value="<?php echo $row['id']; ?>" onClick="edit_chirp(<?php echo $row['content']; ?>)" //THIS DOESNT WORK

My javascript function is

function edit_chirp(somethig)
    {
        alert(somethig);
    }

Console says nothing? What about the rendered HTML, what's it show? — tymeJV, Oct 15 '13 at 13:58
Maybe 'content' is a text, then you must include quote like onClick="edit_chirp('')" — VancleiP, Oct 15 '13 at 13:58
There are no quotes in the characters...just simple characters with spaces — EMAD SEYED, Oct 15 '13 at 13:59
@EMADSEYED And that's why it doesn't work. Look in the [JavaScript error console](http://www.netmagazine.com/tutorials/javascript-debugging-beginners) and you'll see the error. — JJJ, Oct 15 '13 at 14:00
I'm also noticing that in your broken example, you're not closing your input tag with `/>`. — rescuecreative, Oct 15 '13 at 14:02

Voonic · Answer 1 · 2013-10-15T14:11:12.573

1

You have been missing quotes dude. Try this

<input style="float:right" type="image" name="edit_me" id="edit_me"  value="<?php echo $row['id']; ?>" onClick="edit_chirp('<?php echo mysql_real_escape_string($row['content']); ?>')" //THIS WILL WORK

edited Oct 15 '13 at 14:11

answered Oct 15 '13 at 13:59

Voonic

4,419
3
26
56

Yes @shadow it works perfectly. Thank you. – EMAD SEYED Oct 15 '13 at 14:01
1

Well, it doesn't work "perfectly"---it'll break as soon as there are apostrophes in the content or if someone decides to inject malicious JavaScript there. – JJJ Oct 15 '13 at 14:03
@Juhana yep you are right. He can use mysql_real_escape_string for this – Voonic Oct 15 '13 at 14:10
@shadow That's not the right function for this case. At all. – JJJ Oct 15 '13 at 14:22

score 0 · Answer 2 · answered Oct 15 '13 at 14:02

0

Try to add simple quotes in the function call for the parameter. Something like this :

<input style="float:right" type="image" name="edit_me" id="edit_me"  value="<?php echo $row['id']; ?>" onClick="edit_chirp('<?php echo $row['content']; ?>')"

answered Oct 15 '13 at 14:02

guikk

185
5

sending a string from php to javascript function

2 Answers2