How to handle a class name conflict when porting old code?

Question

I'm trying to port an old library (that doesn't use namespaces as far as I can tell) to modern compilers. One of my targets can't tell the difference between System::TObject and ::TObject (without a namespace). System::TObject is native to the compiler.

I've tried a using directive, i.e. using ::TObject;

But that doesn't do it.

The obvious solution is to wrap all the original library in a namespace and then calling it by name- that should avoid the ambiguity. But is that the wisest solution? Is there any other solution? Adding a namespace would require changing a bunch of files and I don't know if it would have unwanted repercussions later.

score 3 · Answer 1 · answered Oct 10 '08 at 04:57

You can do as Dib suggested, with a slight modification:

// In a wrapper header, eg: include_oldlib.h...

namespace oldlib
{
   #include "oldlib.h"
};

#ifndef DONT_AUTO_INCLUDE_OLD_NAMESPACE
using namespace oldlib;
#endif

This allows you to #define the exclusion in only the files where you're getting conflicts, and use all the symbols as global symbols otherwise.

score 1 · Answer 2 · answered Oct 10 '08 at 03:03

1

You could make a wrapper for all the old functions and package them up into a DLL or static library.

answered Oct 10 '08 at 03:03

Adam Pierce

32,221
21
68
87

score 0 · Answer 3 · answered Oct 10 '08 at 02:44

0

If you have the source to the library, maybe include a header file at the top of each source where that header file has only:

#define TObject TMadeUpNameObject

answered Oct 10 '08 at 02:44

Jim Buck

19,934
10
52
73

score 0 · Answer 4 · answered Oct 10 '08 at 02:58

0

Try this:

namespace oldlib
{
   #inclcude "oldlib.h"
};

answered Oct 10 '08 at 02:58

John Dibling

97,027
28
181
313

this will cause the compiler to create symbols prefixed by oldlib, which won't be present in the old library, resulting in `unresolved external symbol "public: __thiscall oldlib::A::~A(void)" (??1A@oldlib@@QAE@XZ)` – xtofl Oct 10 '08 at 09:33

score 0 · Answer 5 · answered Oct 10 '08 at 04:13

I have used the following in the past while encapsulating a third party header file containing classes colliding with the code:

#ifdef Symbol
#undef Symbol
#define Symbol ThirdPartySymbol
#endif
#include <third_party_header.h>
#undef Symbol

This way, "Symbol" in the header was prefixed by ThirdParty and this was not colliding with my code.

How to handle a class name conflict when porting old code?

5 Answers5

Linked

Related