Getting UITableViewCell with superview in iOS 7

Question

I'm getting the UITableViewCell a UIButton belongs to like this:

-(void)buttonHandler:(UIButton *)button {

    OrderCell *cell = [[button superview] superview];
    NSLog(@"cell.item = %@", cell.item.text);

And it works fine in anything before iOS 7. But gives me:

[UITableViewCellScrollView item]: unrecognized selector sent to instance 0x17ae2cf0

if I run the app in iOS 7. BUT if I do:

-(void)buttonHandler:(UIButton *)button {

    OrderCell *cell = [[[button superview] superview] superview];
    NSLog(@"cell.item = %@", cell.item.text);

Then it works in iOS 7 but not earlier?!?!?!

I'm circumventing the issue by doing this:

OrderCell *cell;
if([[[UIDevice currentDevice] systemVersion] isEqualToString:@"7.0"])
    cell = [[[button superview] superview] superview];
else
    cell = [[button superview] superview];

NSLog(@"cell.item = %@", cell.item.text);

but WTF is going on!? Does anyone know why this happens?

Thanks!

Your code was depending on the private subview structure of `UITableViewCell`. Obviously that structure has changed in iOS 7. There are much safer ways to do what you want. And your new code will break under iOS 7.1 and iOS 8. — rmaddy, Sep 23 '13 at 15:14
You could iterate through the superviews, checking if they are of class type UITableViewCell and then return that view ? See answer: — CW0007007, Sep 23 '13 at 15:21

score 27 · Accepted Answer · answered Sep 23 '13 at 15:44

A better solution is to add a category for UIView(SuperView), and calling it by:

UITableViewCell *cell = [button findSuperViewWithClass:[UITableViewCell class]]

This way, your code works for all future and past iOS versions

@interface UIView (SuperView)

- (UIView *)findSuperViewWithClass:(Class)superViewClass;

@end


@implementation UIView (SuperView)

- (UIView *)findSuperViewWithClass:(Class)superViewClass {

    UIView *superView = self.superview;
    UIView *foundSuperView = nil;

    while (nil != superView && nil == foundSuperView) {
        if ([superView isKindOfClass:superViewClass]) {
            foundSuperView = superView;
        } else {
            superView = superView.superview;
        }
    }
    return foundSuperView;
}
@end

This code can be improved by adding a `break` once you find the matching superview. No need to go all the way up to the window every time. — rmaddy, Sep 24 '13 at 01:22

score 13 · Answer 2 · answered Dec 10 '13 at 02:14

13

The best way to do this is:

CGPoint buttonPosition = [sender convertPoint:CGPointZero toView:self.tableView];
NSIndexPath *indexPath = [self.tableView indexPathForRowAtPoint:buttonPosition];
UITableViewCell *cell = (UITableViewCell*)[self.tableView cellForRowAtIndexPath:indexPath];

answered Dec 10 '13 at 02:14

Matt Hudson

7,299
5
48
65

Best answer, very reliable decision – Gennadiy Ryabkin Mar 31 '15 at 08:35

score 3 · Answer 3 · answered Jun 05 '15 at 15:04

To complete the answer of @thomas-keuleers this is the swift method:

extension UIView {

    func findSuperViewWithClass<T>(superViewClass : T.Type) -> UIView? {

        var xsuperView : UIView!  = self.superview!
        var foundSuperView : UIView!

        while (xsuperView != nil && foundSuperView == nil) {

            if xsuperView.self is T {
                foundSuperView = xsuperView
            } else {
                xsuperView = xsuperView.superview
            }
        }
        return foundSuperView
    }

}

and you simply call like that:

child.findSuperViewWithClass(TableViewCell)

child.findSuperViewWithClass(TableViewCell.self) – saurabh Oct 27 '17 at 12:23 — saurabh, Oct 27 '17 at 12:23

PMW · Answer 4 · 2019-05-23T14:56:20.967

0

A shorter Version in swift 5

extension UIView {
   var xsuperView = self.superview

   while xsuperView != nil {
        if let superView = xsuperView.self as? T {
            return superView
        } else {
            xsuperView = xsuperView?.superview
        }
    }
}

edited May 23 '19 at 14:56

answered May 22 '19 at 12:57

PMW

11
3

score -2 · Answer 5 · answered Sep 23 '13 at 15:23

-2

if ([[button superView] isKindOfClass:[UITableViewCell class]]) {

}

else //check next :

answered Sep 23 '13 at 15:23

CW0007007

5,642
3
25
30

Getting UITableViewCell with superview in iOS 7

5 Answers5

Linked