68

I have the following code:

public static async Task<string> Start(IProgress<ProcessTaskAsyncExProgress> progress)
{
    const int total = 10;
    for (var i = 0; i <= total; i++)
    {
        await Task.Run(() => RunLongTask(i.ToString(CultureInfo.InvariantCulture)));
        if (progress != null)
        {
            var args = new ProcessTaskAsyncExProgress
            {
                ProgressPercentage = (int)(i / (double)total * 100.0),
                Text = "processing " + i
            };
            progress.Report(args);
        }
    }
    return "Done";
}

private static string RunLongTask(string taskName)
{
    Task.Delay(300);
    return taskName + "Completed!";
}

How do I get back the string value of RunLongTask from this line: await Task.Run(() => RunLongTask(i.ToString(CultureInfo.InvariantCulture)));?

I've tried:

var val = await Task.Run(() => RunLongTask(i.ToString(CultureInfo.InvariantCulture))).Result;

But I get an error saying "string is not awaitable".

CarenRose
  • 1,234
  • 1
  • 13
  • 21
Null Reference
  • 10,948
  • 39
  • 105
  • 171

2 Answers2

110

Remove the Result from the end. When you await you will get the Result back from the await-able method.

var val = await Task.Run(() => RunLongTask(i.ToString(CultureInfo.InvariantCulture)));
Haris Hasan
  • 29,296
  • 10
  • 87
  • 121
20

This is not a direct answer to old question, but for others searching:

"Normally" you shouldn't do this, but sometimes you need to match a library API so you can use a wrapper function like below:

private async Task<string> WrapSomeMethod(string someParam)
{
    //adding .ConfigureAwait(false) may NOT be what you want but google it.
    return await Task.Run(() => SomeObj.SomeMethodAsync(someParam)).ConfigureAwait(false);
}

And then call that instead with .Result like below:

string blah = WrapSomeMethod(someParam).Result;
Darren
  • 8,064
  • 2
  • 37
  • 48
  • 5
    Using .Result is not recommended, [as it can cause deadlocks](https://stackoverflow.com/questions/15021304/an-async-await-example-that-causes-a-deadlock). – Gabriel Morin May 14 '19 at 21:02
  • 1
    @GabrielMorin Yes "Normally" you shouldn't do this, like 99% of the time. – Darren Nov 22 '19 at 05:56