Is there a way to pass javascript variables in url?

Question

Is there a way to make the below script pass the javascript values to the url of the href link?

<script type="text/javascript">
function geoPreview(lat,long) {
var elemA = document.getElementById("lat").value;
var elemB = document.getElementById("long").value;

window.location.href = "http://www.gorissen.info/Pierre/maps/googleMapLocation.php?lat=elemA&lon=elemB&setLatLon=Set";

}
</script>

score 43 · Accepted Answer · answered Jul 25 '13 at 16:47

43

Try this:

 window.location.href = "http://www.gorissen.info/Pierre/maps/googleMapLocation.php?lat="+elemA+"&lon="+elemB+"&setLatLon=Set";

To put a variable in a string enclose the variable in quotes and addition signs like this:

var myname = "BOB";
var mystring = "Hi there "+myname+"!";

Just remember that one rule!

answered Jul 25 '13 at 16:47

pattyd

5,659
10
37
57

7

Don't stick arbitrary strings directly into a URL. You need to encode them properly with `encodeURIComponent` – Quentin Feb 21 '17 at 11:04
This is a bad practice, do not perform this action without proper sanitisation. – Beyar Jun 26 '20 at 16:27
1

Would be nice to see the correct way to do that if this is retained to be bad practice. – Garavani Jul 15 '21 at 07:33

score 4 · Answer 2 · answered Jul 25 '13 at 16:49

4

Do you mean include javascript variable values in the query string of the URL?

Yes:

 window.location.href = "http://www.gorissen.info/Pierre/maps/googleMapLocation.php?lat="+var1+"&lon="+var2+"&setLatLon="+varEtc;

answered Jul 25 '13 at 16:49

Drew

4,035
3
23
37

2

Don't stick arbitrary strings directly into a URL. You need to encode them properly with `encodeURIComponent` – Quentin Feb 21 '17 at 11:04

score 4 · Answer 3 · answered Aug 24 '18 at 14:59

Summary

With either string concatenation or string interpolation (via template literals).

Here with JavaScript template literal:

function geoPreview() {
    var lat = document.getElementById("lat").value;
    var long = document.getElementById("long").value;

    window.location.href = `http://www.gorissen.info/Pierre/maps/googleMapLocation.php?lat=${lat}&lon=${long}&setLatLon=Set`;
}

Both parameters are unused and can be removed.

Remarks

String Concatenation

Join strings with the + operator:

window.location.href = "http://www.gorissen.info/Pierre/maps/googleMapLocation.php?lat=" + elemA + "&lon=" + elemB + "&setLatLon=Set";

String Interpolation

For more concise code, use JavaScript template literals to replace expressions with their string representations. Template literals are enclosed by `` and placeholders surrounded with ${}:

window.location.href = `http://www.gorissen.info/Pierre/maps/googleMapLocation.php?lat=${elemA}&lon=${elemB}&setLatLon=Set`;

Template literals are available since ECMAScript 2015 (ES6).

score -1 · Answer 4 · edited May 16 '18 at 10:48

-1

Try this:

window.location.href = "http://www.gorissen.info/Pierre/maps/googleMapLocation.php?lat=\''+elemA+'\'&lon=\''+elemB+'\'&setLatLon=Set";

edited May 16 '18 at 10:48

Avnesh Shakya

3,730
2
22
29

answered May 16 '18 at 10:23

Souvik Mukherjee

1

Is there a way to pass javascript variables in url?

4 Answers4

Summary

Remarks

String Concatenation

String Interpolation

Linked

Related