mysql_fetch_assoc() expects parameter 1

Question

I have written a php script for returning every thing in database in json format. The following code is giving me this error.

You have an error in your SQL syntax; check the manual that corresponds to your
MySQL server version for the right syntax to use near ''userCredentials'' at line 1

mysql_fetch_assoc() expects parameter 1 to be resource, boolean given

here is the code:

<?php

require 'testconnect.php';

$sql = "SELECT * FROM 'userCredentials'";

 $query = mysql_query($sql);

 if($query == false){
  echo mysql_error();
echo 'failed query connect';

}
echo 'new success';

while($row = mysql_fetch_assoc($query)) {

  echo json_encode($row);

}

?>

What is wrong with this code? Am I missing something?

PS: I am not PHP programmer. I wrote this script to use this in my java code.

Regards

Only strings need to be concatenated, tables names/rows are enclosed in backticks (`) — samayo, Jul 20 '13 at 18:51

score 2 · Accepted Answer · answered Jul 20 '13 at 18:50

2

This is possibly caused from the fact your using quotes to symbolize a string, you should be using back ticks to identify column names, table names

$sql = "SELECT * FROM 'userCredentials'";

Should be;

$sql = "SELECT * FROM `userCredentials`";

answered Jul 20 '13 at 18:50

Daryl Gill

5,398
8
32
69

how can I enclose the returned json objects in a main json object? – Umer Farooq Jul 20 '13 at 19:21

score 2 · Answer 2 · answered Jul 20 '13 at 18:50

2

Your real error message is You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ''userCredentials'' at line 1

You need to fix your SQL query to read SELECT * FROM userCredentials no single quotes around the table needed.

As other have stated, backticks is the correct way enclose the table name, or any string that could be interpreted incorrectly by mySQL.

answered Jul 20 '13 at 18:50

Steven V

15,889
3
60
74

+1 for the last paragraph. It can be done without back ticks but that may lead to another issue if user is not careful about the naming :) – Fallen Jul 20 '13 at 18:54

score 0 · Answer 3 · answered Jul 20 '13 at 18:51

0

Remove the single quotes arround the table name instead you can use back ticks

$sql = "SELECT * FROM `userCredentials`";

answered Jul 20 '13 at 18:51

M Khalid Junaid

62,293
9
87
115

mysql_fetch_assoc() expects parameter 1

3 Answers3