Can't figure out what this syntax error is

Question

I'm currently learning PHP through tutorials and I am trying to run the following code but getting an unexplained syntax error which no one else seems to be having occur with them.

Error Message Parse error: syntax error, unexpected ';' in ..../users.php on line 12

Line 12 =

return (mysql_result(mysql_query("SELECT `user_id` FROM `users` WHERE `username` = '$username'"), 0, 'user_id');

Full page Code

<?php
function user_exists($username) {
$username = sanitize($username);
return (mysql_result(mysql_query("SELECT COUNT(`user_id`) FROM `users` WHERE `username` = '$username'"), 0) == 1) ? true : false;
}
function user_active($username) {
$username = sanitize($username);
return (mysql_result(mysql_query("SELECT COUNT(`user_id`) FROM `users` WHERE `username`    = '$username' AND `active` =1"), 0) ==1) ? true : false;
}
function user_id_from_username ($username) {
$username = sanitize($username);
return (mysql_result(mysql_query("SELECT `user_id` FROM `users` WHERE `username` = '$username'"), 0, 'user_id');
}
function login ($username, $password) {
$user_id = user_id_from_username($username);

$username = sanitize($username);
$password = md5($password);

return(mysql_result(mysql_query("SELECT COUNT (`user_id`) FROM `users` WHERE `username` = '$username' AND `password` = '$password'"), 0) == 1) ? $user_id : false;


}
?>

score 5 · Answer 1 · answered Jul 09 '13 at 04:27

5

you are missing a closing parentheses ) you have 3 opening but only 2 closing...

answered Jul 09 '13 at 04:27

Joe T

2,291
1
17
28

score 4 · Accepted Answer · edited Jul 09 '13 at 04:36

4

One more closing round bracket.

                                                           /* v */
return (mysql_result(mysql_query("..."), 0, 'user_id')/* -> */)/* <- */;
                                                           /* ^ */

edited Jul 09 '13 at 04:36

Orangepill

24,308
3
40
63

answered Jul 09 '13 at 04:27

sectus

15,278
5
51
91

2

A comment would make sense – zerkms Jul 09 '13 at 04:27
Thank you, that worked, it just didn't make sense to me on the tutorial I copied the code exactly and the lecturer had no such issues, thanks for your help. – user2542256 Jul 09 '13 at 04:29
1

+1 for the attention getting comments – Orangepill Jul 09 '13 at 04:31
Look for a tutorial on [mysqli](http://www.phphaven.com/article.php?id=65) or [PDO](http://net.tutsplus.com/tutorials/php/why-you-should-be-using-phps-pdo-for-database-access/). – Herbert Jul 09 '13 at 04:32
@user2542256, lecturer? – sectus Jul 09 '13 at 04:34
@zerkms I wasn't copy and pasting, I was watching a video while typing the code myself. – user2542256 Jul 09 '13 at 05:17

score 0 · Answer 3 · answered Jul 09 '13 at 04:29

Try this,

function user_id_from_username ($username) {
    $username = sanitize($username);
    return (mysql_result(
          mysql_query(
                "SELECT `user_id` FROM `users` WHERE `username` = '$username'"
           ), 0
    ), 'user_id');
}

Can't figure out what this syntax error is

3 Answers3