39

I'm implementing a shopping cart and want to store the data in localStorage. I want to watch the variable $scope.cart for change so that I can update the localStorage

The cart variable looks like this:

[{'name':'foo', 'id':'bar', 'amount': 1 },...]

This is the code for the watch.

$scope.updateCart = function(){
    localStorageService.add('cart',JSON.stringify($scope.cart));
    alert('cart updated');
};

$scope.$watch($scope.cart, $scope.updateCart(), true);

This is the HTML where the user changes the model.

<li ng-repeat="item in cart">
  {{item.name}} <input type="text" ng-model="item.amount">
</li>

With the following code, the updateCart() method is never triggered. I'm not sure what I'm doing wrong. I check that the $scope.cart variable did change, but the update was not triggered.

Oleg
  • 9,131
  • 2
  • 44
  • 56
harinsa
  • 3,096
  • 4
  • 31
  • 52

3 Answers3

41

$watch only evaluate string or function parameter in its first argument. Change your $watch like this :

$scope.$watch('cart.name + cart.id + cart.amount', $scope.updateCart());

OR

$scope.$watch('cart', $scope.updateCart, true);

See reference API

Rubens Mariuzzo
  • 27,091
  • 26
  • 115
  • 147
EpokK
  • 37,948
  • 9
  • 59
  • 68
28

It is a common mistake to use a variable as the first parameter to the watch expression.

For $scope.cart, you should use the string cart:

$scope.$watch('cart', function () {...}, true)

AngularJs has a new watch method, $watchCollection. It is basically the same as $watch with the object equality option set to true, to watch for a change in a property or an array item.

$scope.$watchCollection('cart', function () {...});

Documentation: $watchCollection.

Lee Goddard
  • 9,582
  • 3
  • 45
  • 56
Jin
  • 1,056
  • 10
  • 10
  • 6
    $watchColletion saved me, when pushing / removing items from an array. Thanks! – Ziarno May 12 '15 at 14:58
  • 1
    It's unclear what kind of change the OP wanted, but [as seen here](http://stackoverflow.com/a/29189252/1175496) `$watch(.., .., true)` detects even more changes, namely this type of change: `$scope.cart[0].name= "Foo Bar";` – The Red Pea Nov 27 '16 at 17:26
1

try to change

$scope.$watch($scope.cart, $scope.updateCart(), true);

to

$scope.$watch('cart', $scope.updateCart(), true);

$watch only evaluate string or function parameter in its first argument

Blazemonger
  • 86,267
  • 25
  • 136
  • 177
Roger Jin
  • 553
  • 5
  • 15