How to ouput multi-line html with variable into div using javascript?

Question

I want to output this multi line html with variable into div from inside jquery but it never ouput the block of code inside div! I am using only variable inside it which is"itemName". could any one tell me why my code doesn't out to div ?

var siteContents2 ="<li> +
"       <iframe src='<iframe src='http://bsite.com/itemshow.php?"+itemName+"&title=ok&bgcolor=white' height=200 width=200 style='border: none;></iframe><br>+
"        <div class="details">+
"        <div class="title">+
"          <a href="/+itemName/">+itemName</a>+
"        </div>+
"        </div>+
"    </li> ";   

document.getElementById("myDiv").innerHTML += siteContents2;


</script>   
</head>

<body>

    <div id="myDiv"></div>

score 2 · Answer 1 · answered May 10 '13 at 08:38

2

Your quotes and concats are not correct. try this:

var siteContents2 ="<li>" + 
 "       <iframe src='<iframe src='http://bsite.com/itemshow.php?"+itemName+"&title=ok&bgcolor=white' height=200 width=200 style='border: none;></iframe><br> "+
"        <div class='details'>"+
"        <div class='title'>"+
"          <a href='/"+itemName+"/'>"+itemName+"</a>"+
"        </div>"+
"        </div>"+
"    </li> ";

answered May 10 '13 at 08:38

krampstudio

3,231
2
40
56

Thanks . It worked well .could you tell me how i append these blocks of

user1788736

May 10 '13 at 09:33

i am trying to append the sitecontents2 to a div in body of page since am calling this script multiple time and want to arrange these outputs in rows of 5. Now each time i call the script it puts each iframe below each other. My goal is to have 5 iframe in a row! – user1788736 May 10 '13 at 09:51

so add your content in a sublist and add a new item to the parent list once the sublist size contains 5 items – krampstudio May 10 '13 at 10:05

score 2 · Answer 2 · edited Jul 26 '17 at 06:16

Since ES6, you can store multi-line variables as template literals by surrounding them with backticks (`s):

var siteContents2 =`<li> 
       <iframe src='<iframe src='http://bsite.com/itemshow.php?`+itemName+`&title=ok&bgcolor=white' height=200 width=200 style='border: none;></iframe><br>
       <div class='details'>
       <div class='title'>
       <a href='`+itemName+`'>`+itemName+`</a>
    </div>
    </div>
</li> `; 
document.getElementById("myDiv").innerHTML += siteContents2;

More on template literals here.

ashfp · Answer 3 · 2013-05-10T08:52:15.323

You're missing some quotes from the end of some of the lines and you can use either single quotes (') or an escaped double quote (\") within the html.

var siteContents2 ="<li> "+
"       <iframe src='<iframe src='http://bsite.com/itemshow.php?"+itemName+"&title=ok&bgcolor=white' height=200 width=200 style='border: none;></iframe><br>"+
"        <div class='details'>"+
"        <div class='title'>"+
"          <a href='"+itemName+"'>"+itemName+"</a>"+
"        </div>"+
"        </div>"+
"    </li> ";   

document.getElementById("myDiv").innerHTML += siteContents2;

Mario Zigliotto · Answer 4 · 2013-05-10T17:53:44.150

Your code had erroneous quotes throughout it so it was technically an invalid string and most likely being rejected. In addition, you can do multiline strings by ending each line with a \ so you don't have to worry about so many quotes.

Your code, rewritten and working, could look like this:

var itemName = "blahblah";
var siteContents2 = "<li>\
       <iframe src='http://bsite.com/itemshow.php?" + itemName + "&title=ok&bgcolor=white' height=200 width=200 style='border: none;'></iframe>\
        <br>\
        <div class='details'>\
            <div class='title'>\
              <a href='" + itemName + "'>" + itemName + "</a>\
            </div>\
        </div>\
    </li>";

document.getElementById("myDiv").innerHTML += siteContents2;

Here's a jsFiddle of the code: http://jsfiddle.net/vkaC8/

Ah you're right there was an error, sorry about that. The iframe was output but it's mark up was invalid because the code in you're initial question didn't have the trailing ' on this part: `style='border: none;'` and when i copied/edited the code i didn't realize that was missing. :/ I added the apostrophe and added a jsFiddle so you can check my version if you feel like it. — Mario Zigliotto, May 10 '13 at 17:56

How to ouput multi-line html with variable into div using javascript?

4 Answers4