79

I've had this working in some other project before, I am just re-doing the same thing but for some reason it's not working. The Spring @Value is not reading from property file, but instead it's taking the value literally

AppConfig.java

@Component
public class AppConfig
{
    @Value("${key.value1}")
    private String value;

    public String getValue()
    {
        return value;
    }
}

applicationContext.xml:

<context:component-scan
    base-package="com.test.config" />
<context:annotation-config />

<bean id="appConfigProperties"
    class="org.springframework.beans.factory.config.PropertyPlaceholderConfigurer">
    <property name="location" value="classpath:appconfig.properties" />
</bean>

appconfig.properties

key.value1=test value 1

In my controller, where I have:

@Autowired
private AppConfig appConfig;

The application starts just fine, but when I do

appConfig.getValue()

it returns

${key.value1}

It doesn't resolve to the value inside the properties file.

Thoughts?

ROMANIA_engineer
  • 51,252
  • 26
  • 196
  • 186
TS-
  • 4,121
  • 8
  • 39
  • 52
  • 5
    Duplicated http://stackoverflow.com/questions/11890544/spring-value-annotation-in-controller-class-not-evaluating-to-value-inside-pro and http://stackoverflow.com/questions/5275724/spring-3-0-5-doesnt-evaluate-value-annotation-from-properties – pedjaradenkovic Apr 10 '13 at 22:29
  • Thanks! didn't find that thread, most the ones I found was related to the value being NULL – TS- Apr 11 '13 at 12:55

11 Answers11

74

I also found the reason @value was not working is, @value requires PropertySourcesPlaceholderConfigurer instead of a PropertyPlaceholderConfigurer. i did the same changes and it worked for me, i am using spring 4.0.3 release. I configured this using below code in my configuration file -

@Bean 
public static PropertySourcesPlaceholderConfigurer propertySourcesPlaceholderConfigurer() {
return new PropertySourcesPlaceholderConfigurer();
}
Sachchidanand Singh
  • 1,356
  • 1
  • 12
  • 15
36

In my case, static fields will not be injected.

User007
  • 701
  • 7
  • 11
20

Problem is due to problem in my applicationContext.xml vs spring-servlet.xml - it was scoping issue between the beans.

pedjaradenkovic kindly pointed me to an existing resource: Spring @Value annotation in @Controller class not evaluating to value inside properties file and Spring 3.0.5 doesn't evaluate @Value annotation from properties

Community
  • 1
  • 1
TS-
  • 4,121
  • 8
  • 39
  • 52
13

In my case I was missing the curly braces. I had @Value("foo.bar") String value instead of the correct form @Value("${foo.bar}") String value

Naruto Sempai
  • 4,447
  • 5
  • 32
  • 50
9

for Sprig-boot User both PropertyPlaceholderConfigurer and the new PropertySourcesPlaceholderConfigurer added in Spring 3.1. so it's straightforward to access properties file. just inject

Note: Make sure your property must not be Static

@Value("${key.value1}")
private String value;
Dapper Dan
  • 802
  • 10
  • 21
4

I was using spring boot, and for me upgrading the version from 1.4.0.RELEASE to 1.5.6.RELEASE solved this issue.

craastad
  • 5,624
  • 5
  • 30
  • 44
2

In my case, I had the lombok @AllArgsConstructor and that picked up the property as well. Deleting this annotation solved the problem.

Ahmed Aziz
  • 331
  • 5
  • 14
1

Have a read of pedjaradenkovic's comment.

Further to the link he provides, the reason this isn't working is that @Value processing requires a PropertySourcesPlaceholderConfigurer instead of a PropertyPlaceholderConfigurer.

Muel
  • 4,152
  • 1
  • 22
  • 32
  • 1
    PropertyPlaceholderConfigurer works just fine for me. I just needed to fix the context:component-scan in my app context xml and spring servlet xml – TS- Apr 11 '13 at 12:56
  • @TS what version of spring are you using, please? – Muel Apr 11 '13 at 13:15
  • Can't you @Autowire Environment instead? see http://stackoverflow.com/a/15562319/632293 – jediz Apr 01 '16 at 16:08
1

@Value sometimes can take a day or a half to get resolved ;).

Here is what I did :

  1. Add property to properties or YAML file

  2. Make Sure MAIN CLASS IS ANNOTATED WITH @EnableAutoConfiguration OR @SpringBootApplication

  3. CREATE AppConfig IN WHICH YOU CAN USE @Value

    @Value("${PROPERTY}") private String URL;

Annotate this AppConfig with @Configuration at class level

  1. SO FAR SETUP IS DONE NOW USE IT WHEREVER YOU WANT BY AUTOWIRING AppConfig

EXAMPLE: IN SOME SERVICE @Autowired private AppConfig appConfig; AND IN THE METHOD OF THIS SERVICE call appConfig.getUrl() to get the value of property URL from a properties file.

NOTE: DON'T TRY TO GET VALUE IN CONSTRUCTOR OF SERVICE IT WILL BE NULL.

Dharman
  • 26,923
  • 21
  • 73
  • 125
Shirish Singh
  • 557
  • 5
  • 12
  • Thank you so much - that was my point 'NOTE: DON'T TRY TO GET VALUE IN CONSTRUCTOR OF SERVICE IT WILL BE NULL.' – Tony Feb 18 '22 at 14:41
0

Please note that if you have multiple application.properties files throughout your codebase, then try adding your value to the parent project's property file.

You can check your project's pom.xml file to identify what the parent project of your current project is.

Alternatively, try using environment.getProperty() instead of @Value.

Janac Meena
  • 2,505
  • 24
  • 29
0

Mine was casued by importing a wrong dependency. I had it imported from lombok by accident instead of "import org.springframework.beans.factory.annotation.Value;" Changing it back solved the problem

Etienne Kaiser
  • 2,634
  • 8
  • 19
  • 29
emily
  • 35
  • 1
  • 9