Java class, what is the best pratice for setting values in class constructor?

Question

For example I have a class

class1:

public class car{
private Color carColor;
public car(Color carColor)
{
    this.carColor = carColor;
}

public void setColor(Color carColor)
{
    this.carColor = carColor;
}
}

class2:

public class car{
    private Color carColor;
    public car(Color carColor)
    {
        setColor(carColor);
    }

    public void setColor(Color carColor)
    {
        this.carColor = carColor;
    }
}

Which Constructor would be the best practice in java coding and why?

Both constructors are semantically the same. Best practice? I would say none, make it as you want. — Luiggi Mendoza, Mar 31 '13 at 19:22
I generally try to avoid using non-private methods inside constructor since they can be overriden in derived class and used in `super` constructor instead of original method. — Pshemo, Mar 31 '13 at 19:24

score 2 · Answer 1 · edited May 23 '17 at 12:28

2

The first way is more intuitive and shows up more often. i.e. like so:

public car(Color carColor)
{
    this.carColor = carColor;
}

It is more readable. But both are equal so it's a style issue.

See this too: Should I initialize variable within constructor or outside constructor

edited May 23 '17 at 12:28

Community

1
1

answered Mar 31 '13 at 19:22

Caffeinated

11,134
39
115
205

2

This should be a comment rather than an answer. – Luiggi Mendoza Mar 31 '13 at 19:23
4

@LuiggiMendoza why? It's easy question that may require simple answer... – dantuch Mar 31 '13 at 19:23
Because this is a personal opinion rather than an answer supported by facts, references, or specific expertise. – Luiggi Mendoza Mar 31 '13 at 19:24

score 2 · Accepted Answer · answered Mar 31 '13 at 19:24

2

I'd use the first option, since you can have a validation within setColor().

answered Mar 31 '13 at 19:24

Eng.Fouad

111,301
67
311
403

Maybe you should apply that validation when instantiating the object too =\ (which leads to debate...) – Luiggi Mendoza Mar 31 '13 at 19:25

score 1 · Answer 3 · answered Mar 31 '13 at 19:24

1

Class1 I suppose. Getter and Setter methods are usually necessary but it is the job of the Constructor to initialize variables of that object.

answered Mar 31 '13 at 19:24

RyPope

2,495
25
46

score 1 · Answer 4 · answered Mar 31 '13 at 19:24

If I have many calculations that should be done on the variable before setting it, I would do it in a separate method, otherwise, I would choose the first approach.

public car(Color carColor)
{
    setColor(carColor);
}

public void setColor(Color carColor)
{
    Color res;
    //Many calculations
    //..
    //..
    //finally 
    this.carColor = res;
}

But if I only want to set it, I would simple:

public car(Color carColor)
{
    this.carColor = carColor;
}

Java class, what is the best pratice for setting values in class constructor?

4 Answers4