editText.toString=="something" always false

Question

I am trying to check if text in editText is equal to some string. This is my if (it comes every time i press a button):

if(tx.getText().toString()=="bla")

this is tx: tx=(EditText)findViewById(R.id.editText1);

I don't know why but the if is never true, I tried to check it by toast this way:

Toast.makeText(getApplicationContext(),tx.getText().toString(), Toast.LENGTH_LONG).show();

and it is "bla" but still its false, why?

you can use tx.getText().toString().equals("bla") in place of == and its work. — Ganpat Kaliya, Sep 25 '15 at 09:32

Pragnani · Answer 1 · 2013-03-24T18:43:32.450

4

You should use equals

if(tx.getText().toString().equals("bla"))

equals compares the string, but == compares the objects.

As @Frank suggested in order to avoid NPE compare like this

if("bla".equals(tx.getText().toString()))

edited Mar 24 '13 at 18:43

answered Mar 24 '13 at 18:36

Pragnani

20,035
6
47
74

1

and put the "bla" literal first, avoid nullpointers.. – Frank Mar 24 '13 at 18:37
thank you very much. im sorry for this stupid question i will try to search more next time, i tought this is something more complex. – Mar 24 '13 at 18:42

score 1 · Answer 2 · answered Mar 24 '13 at 18:37

1

You have not use "==" for testing equality of two strings.Use equals method of String class.

answered Mar 24 '13 at 18:37

hasanghaforian

13,498
9
73
157

score 1 · Answer 3 · answered Mar 24 '13 at 18:38

1

When you compare two String objects, you don't compare their literal value. You check if they are the same object, which is usually not the case. That's why you want to use mystring.equals("my string litereal") instead.

answered Mar 24 '13 at 18:38

NullData

386
2
8

editText.toString=="something" always false

3 Answers3