Toast coming Multiple Times

Question

In my application , on a button click I am creating a Toast as -

Toast.makeText(context,"Please Enter Username",Toast.LENGTH_SHORT).show();

But when someone clicks on the button 5-6 times and closes the application, or goes on another screen, it still keeps on showing the Toast for sometime on another screen also. I have seen many solutions for the same.

I have tried -

toast = Toast.makeText(LoginActivity.this, message, Toast.LENGTH_SHORT);
        toast.show();

and have cancelled this toast-

onPause(){

if(toast!=null){
toast.cancel();

}

and same on onDestroy()

I want that when anyone clicks on the button 5-6 times and goes out of the app or that activity, the toast message should disappear. Or suggest any alternate to solve the same.

Just disable button after 1 click on button so u don't have requirement for cancel Toast. — Dixit Patel, Jan 13 '13 at 04:51
http://stackoverflow.com/questions/12922516/how-to-prevent-multiple-toast-overlaps — Ciro Santilli Путлер Капут 六四事, Feb 02 '16 at 16:26

Sam · Answer 1 · 2013-01-13T05:44:18.713

16

But it gives me a force close as - Toast was never called by using Toast.makeText();

You can make a field variable and method to only display one Toast at a time:

Toast toast;

public void displayToast(String message) {
    if(toast != null)
        toast.cancel();
    toast = Toast.makeText(context, message, Toast.LENGTH_SHORT);
    toast.show();
}

And in onPause() cancel any existing Toast when you exit:

protected void onPause() {
    if(toast != null)
        toast.cancel();
    super.onPause();
}

Now whenever you want to display a Toast, simply call:

displayToast("Please Enter Username");

edited Jan 13 '13 at 05:44

answered Jan 13 '13 at 04:48

Sam

85,827
19
179
175

I have now tried as u have suggested, but Toast is not getting cleared. Force Close problem is resolved. But toast is not cancelling when I exit from the app or go to any another activity. Please help – Gaurav Arora Jan 13 '13 at 05:03
See I have upvoted you on other posts also. I will accept your answer as well, but if you can solve my other problem also bro. – Gaurav Arora Jan 13 '13 at 05:42
You don't have to upvote my other answers, in fact Stack Overflow automatically catches and removes "robo-voting". I edited my answer so you have the chance to undo your downvote, if you want. – Sam Jan 13 '13 at 05:46
@Sam AWESEOME tutorials! Thanks – Si8 Aug 16 '13 at 15:17

Nimish Choudhary · Answer 2 · 2013-01-13T07:31:50.177

Try this :

Toast mToast;

  @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);
        mToast = Toast.makeText(this, "", Toast.LENGTH_SHORT);
      }

    @Override
    protected void onPause() {
        mToast.cancel();
        // TODO Auto-generated method stub
        super.onPause();
    }

    public void abc(View c) {

        mToast.cancel();
        mToast.setDuration(Toast.LENGTH_SHORT);
        mToast.setText("This is hi" + (i++));
        mToast.show();

    }

instead of using 'Toast.makeText' use 'mToast.setText("")' this way you will achieve your desired output.

Toast coming Multiple Times

2 Answers2