javascript replace function only replaces the first occurance

Question

document.getElementById("Message").innerHTML=document.getElementById("Message").innerHTML.replace("'","%%");

The above statement replaces only the first occurrence of the single quote. Could it be because that I do a submit right after that, and that javascript doesn't wait for the previous statement to be completed before moving on to the next one?

score 3 · Accepted Answer · answered Sep 26 '12 at 15:40

3

Try using regex /g

.replace(/'/g,"%%")

Change your code as below,

document.getElementById("Message").innerHTML = 
                  document.getElementById("Message")
                          .innerHTML
                          .replace(/'/g,"%%");

answered Sep 26 '12 at 15:40

Selvakumar Arumugam

78,145
14
119
133

score 0 · Answer 2 · edited May 23 '17 at 12:06

0

To replace globally in javascript you need to add /g to the replacement string.

See this SO link How to replace all dots in a string using JavaScript

edited May 23 '17 at 12:06

Community

1
1

answered Sep 26 '12 at 15:40

iivel

2,566
22
19

score 0 · Answer 3 · answered Sep 26 '12 at 15:40

0

You should use regular expression in replace.

document.getElementById("Message").innerHTML=document.getElementById("Message").innerHTML.replace(/'/g,"%%");

jsfiddle

answered Sep 26 '12 at 15:40

Anoop

22,496
10
60
70

score 0 · Answer 4 · answered Sep 26 '12 at 15:41

0

Use the Global (g) flag in the replace() parameters.

See here

answered Sep 26 '12 at 15:41

Alberto De Caro

5,049
9
43
72

score 0 · Answer 5 · answered Sep 26 '12 at 15:42

0

You should use a regular expression and the /g (global) flag. This will replace all occurrences:

document.getElementById("Message").innerHTML=
    document.getElementById("Message").innerHTML.replace(/'/g,"%%");

http://www.w3schools.com/jsref/jsref_replace.asp

answered Sep 26 '12 at 15:42

Pete

2,488
10
15

[Handle W3Schools with care](http://stackoverflow.com/questions/8052158/alternative-to-w3schools-mozilla-developer-network) – Alberto De Caro Sep 26 '12 at 15:59
@ADC Yeah, but it offered a short, ambiguous answer accompanied with zero explanation and really great SEO. Though, I guess I'm just adding to the page rank with my reference. O_o – Pete Sep 26 '12 at 18:06

javascript replace function only replaces the first occurance

5 Answers5