1

i have an issue doing toggleClass it doesn't seem to work properly. the image should change in between show and hide. It does change in to hide, but no back

here is my example and some code:

<div class="top_menu_hidden" style="display: none; ">testing</div>
<div class="show_menu"></div>

$('.show_menu').on('click', function(){
        $('.top_menu_hidden').stop().slideToggle('normal', function(){
            $(".show_menu").toggleClass("hide_menu show_menu");
        });
});​

.show_menu{
    background: url("http://placehold.it/150&text=show") no-repeat scroll 0 0 transparent;
    height: 150px;
    width: 150px;
}
.hide_menu{
    background: url("http://placehold.it/150&text=hide") no-repeat scroll 0 0 transparent;
    height: 150px;
    width: 150px;
}

any ideas?

thanks

Patrioticcow
  • 25,174
  • 72
  • 208
  • 332

2 Answers2

5
$(".show_menu, .hide_menu").toggleClass("hide_menu show_menu");

DEMO

Full code

$('.show_menu').on('click', function() {
    $('.top_menu_hidden').stop().slideToggle('normal', function() {
        $(".show_menu, .hide_menu").toggleClass("hide_menu show_menu");
    });
});
thecodeparadox
  • 84,459
  • 21
  • 136
  • 161
4

There is a toggle function that does it for you out of the box:

$(".show_menu").toggle();

toggle docs:

Description: Display or hide the matched elements.

gdoron is supporting Monica
  • 142,542
  • 55
  • 282
  • 355