Is it okay to change the vendor files?

Question

I am using magento 2.1 with the ultimo theme. I was customizing the login page which was not avaialable as a module in the theme.

So I go to vendor and changed the login page setting like text and placement of new register and old customer login place.

I want to ask is it okay to change these files . I know after the changes I have to compile so that these changes make it to the pub.

But in the vendor what should be done for the best practice.

P.S the path is /vendor/magento/module-customer/view/frontend/templates/newcustomer.phtml

changing any file in vendor is not the right way, its total wrong way... extend your module under your ultimo theme.. — Manoj Deswal, Sep 27 '17 at 15:08
@ManojDeswal how ? i have already extended the ultimo theme. — tech_geek, Sep 27 '17 at 15:09
extend customer module under ultimo theme... let me see the your theme directory then I ll tell you where to place the files — Manoj Deswal, Sep 27 '17 at 15:11

score 5 · Answer 1 · answered Sep 27 '17 at 15:33

5

To make changes in your customer module , copy file from vendor at path you changing right now

/vendor/magento/module-customer/view/frontend/templates/newcustomer.phtml

And place at following location in your theme, if folders are not present then you can create them. Copy only required file , no need to copy all the files

/app/design/frontend/Infortis/base/Magento_Customer/templates/newcustomer.phtml

Make your changes and run required commands to take effect.

In same way you can extend any module which is not present in your theme

Never make any changes in vendor files , always extend the module

answered Sep 27 '17 at 15:33

Manoj Deswal

5,785
25
27
50

1

Thank you manoj i wish i could accept the both answers. cheers! – tech_geek Sep 27 '17 at 15:36
No worry bro.. Happy to help people here on forums . cheers ! – Manoj Deswal Sep 27 '17 at 15:38
some day i will return this favor by helping others when i got some command on this technology. – tech_geek Sep 27 '17 at 15:39
1

sure, always help other with your knowledge , this way you will learn more – Manoj Deswal Sep 27 '17 at 15:40
i have a question what if i want to change something in the block ? then i have to put it in the block ? i mean what directory structure should be in the new custom theme folder? – tech_geek Sep 28 '17 at 06:17
check here https://stackoverflow.com/questions/39424290/magento-2-override-rewrite-block-model-controller-helper-using-plugin-pref – Manoj Deswal Sep 28 '17 at 06:21
but i only want to change one file i want to change the title so that what in the Block>Form>Login.php. – tech_geek Sep 28 '17 at 07:47
whatever you need to change , always do in your extended module – Manoj Deswal Sep 28 '17 at 07:48
So by making a block directory in the Magento_Customer and changing it will work? – tech_geek Sep 28 '17 at 07:50
1

No not that way, check the answer link I given – Manoj Deswal Sep 28 '17 at 08:09

score 3 · Accepted Answer · edited Sep 28 '17 at 06:49

3

No this is not best practice. If you run any updates these changes will get overwritten. Any patches that are applied may fail if the files are different from originals as well.

You can, however, do this from within your theme. From your ultimo theme's root directory create new folders for that module Magento_Customer/templates.

Then copy the vendor file to your new folder:

Magento_Customer/templates/newcustomer.phtml

Then make modifications to your new file from there.

edited Sep 28 '17 at 06:49

Mohit Kumar Arora

9,951
7
27
55

answered Sep 27 '17 at 15:22

harri

5,465
6
44
100

actually there is nothing like Magento_Customer. Also there is xml file in view which i also want to change i want to change the settings of the block thats why – tech_geek Sep 27 '17 at 15:24
Yeah add the folders in there . – harri Sep 27 '17 at 15:27
The xml file will go within Magento_Customer/layout/ you can make changes to xml from there. – harri Sep 27 '17 at 15:28
thats what i am saying that there is not any folder like magento_customer in ultimo . Do i have to make one? and which files should i copy. It will automatically pick up the files which i have changed from this new directory and old files from vendor? – tech_geek Sep 27 '17 at 15:29
Yeah so create the new directories Magento_Customer , and templates within that. These files will now be used instead of vendor files. – harri Sep 27 '17 at 15:31
all the files or only the files which i want to change ? – tech_geek Sep 27 '17 at 15:32
Just the files you want to change – harri Sep 27 '17 at 15:35
Looks good. thank you for your help harri! – tech_geek Sep 27 '17 at 15:36
If i want to change the block the procedure is same ? – tech_geek Sep 28 '17 at 07:51
What is the file you want to change? – harri Sep 28 '17 at 07:52
Login.php i want to change the title – tech_geek Sep 28 '17 at 07:52
This is more for a module where you can override the block see: https://magento.stackexchange.com/questions/134093/how-to-override-blocks-in-v2-1/134106 Within theme however you can create customer_account_login.xml with some code. – harri Sep 28 '17 at 07:57
Let us continue this discussion in chat. – harri Sep 28 '17 at 07:57
i have understand but what how would i know the action methods that which method i should change. Like in this case we are changing the title method. – tech_geek Sep 28 '17 at 08:07
I'm not sure i can give a great answer to this i think this would make a decent question on its own I will try look for something regarding this. – harri Sep 28 '17 at 08:08
sure it will be a great help – tech_geek Sep 28 '17 at 08:09

Is it okay to change the vendor files?

2 Answers2